Skip to content

refactor(charts): explicitly define change detection strategy#2187

Merged
spike-rabbit merged 1 commit into
mainfrom
refactor/charts-explicit-change-detection-strategy
Jun 23, 2026
Merged

refactor(charts): explicitly define change detection strategy#2187
spike-rabbit merged 1 commit into
mainfrom
refactor/charts-explicit-change-detection-strategy

Conversation

@spliffone

@spliffone spliffone commented Jun 19, 2026

Copy link
Copy Markdown
Member

@spliffone spliffone requested review from a team as code owners June 19, 2026 08:31

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request explicitly configures several chart components and test hosts to use ChangeDetectionStrategy.Default and imports the strategy accordingly. The reviewer correctly points out that since Default is already the default change detection strategy in Angular, explicitly defining it is redundant and adds unnecessary boilerplate. It is recommended to remove these redundant imports and configuration properties across all modified files to keep the codebase clean and aligned with the style guide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread projects/charts-ng/cartesian/si-chart-cartesian.component.ts
Comment thread projects/charts-ng/cartesian/si-chart-cartesian.component.ts
Comment thread projects/charts-ng/chart/si-chart.component.ts
Comment thread projects/charts-ng/chart/si-chart.component.ts
Comment thread projects/charts-ng/circle/si-chart-circle.component.spec.ts
Comment thread projects/charts-ng/sankey/si-chart-sankey.component.ts
Comment thread projects/charts-ng/sunburst/si-chart-sunburst.component.spec.ts
Comment thread projects/charts-ng/sunburst/si-chart-sunburst.component.spec.ts
Comment thread projects/charts-ng/sunburst/si-chart-sunburst.component.ts
Comment thread projects/charts-ng/sunburst/si-chart-sunburst.component.ts

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit spike-rabbit added this pull request to the merge queue Jun 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 23, 2026
@spike-rabbit spike-rabbit added this pull request to the merge queue Jun 23, 2026
Merged via the queue into main with commit 281b72f Jun 23, 2026
18 checks passed
@spike-rabbit spike-rabbit deleted the refactor/charts-explicit-change-detection-strategy branch June 23, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants